Optimize pretty printing performance #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
allevato and
shawnhyam
as code owners
|
CC @macshome |
|
Some instruction counts (for formatting swift-syntax 509.0.0):
Still worse than it was, but we're doing a fair bit more work so that seems inevitable. |
bnbarham
force-pushed
the
pretty-print-perf
branch
from
d600848 to
600235a
Compare
rintaro
reviewed
Jan 10, 2025
rintaro
reviewed
Jan 10, 2025
|
I would do: if let lastNewlineIndex = text.utf8.lastIndex(of: UInt8(ascii: "\n")) {
let lastLineStart = text.utf8.index(after: lastNewlineIndex)
lineNumber += text[..<lastLineStart].utf8.count(where: {$0 == UInt8(ascii: "\n")})
column = text[lastLineStart...].count
} else {
column += text.count
} |
swift-format#883 fixed outputting incorrect line numbers, but introduced a performance regression. swift-format#901 improved this back to around the original, but had to be reverted as it introduced a an issue due to counting codepoints rather than characters. Introduce a similar optimization again, but only for the first portion of the string (prior to the last newline). Fixes swift-format#894 again.
|
Ah, thanks @rintaro. We're now down to 68032409793 👍 |
bnbarham
force-pushed
the
pretty-print-perf
branch
from
600235a to
3ca204b
Compare
allevato
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#883 fixed outputting incorrect line numbers, but introduced a performance regression. #901 improved this back to around the original, but had to be reverted as it introduced a an issue due to counting codepoints rather than characters.
Introduce a similar optimization again, but only for the first portion of the string (prior to the last newline).
Fixes #894 again.